From 20c764fc5ea09f0f0160bdf5e57946eccd56613c Mon Sep 17 00:00:00 2001 From: Bastien Nocera Date: Mon, 17 Mar 2014 09:27:36 +0100 Subject: [PATCH] dialog: Avoid possible use-after-free When the dialogue's titlebar was replaced, we were still trying to update the label we constructed but that was now destroyed. https://bugzilla.gnome.org/show_bug.cgi?id=726492 --- gtk/gtkdialog.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gtk/gtkdialog.c b/gtk/gtkdialog.c index 3b54c46b00..19039ba27f 100644 --- a/gtk/gtkdialog.c +++ b/gtk/gtkdialog.c @@ -304,7 +304,7 @@ apply_use_header_bar (GtkDialog *dialog) label = gtk_label_new (""); gtk_style_context_add_class (gtk_widget_get_style_context (label), "title"); gtk_box_set_center_widget (GTK_BOX (box), label); - g_signal_connect (dialog, "notify::title", G_CALLBACK (update_title), label); + g_signal_connect_object (dialog, "notify::title", G_CALLBACK (update_title), label, 0); } gtk_window_set_titlebar (GTK_WINDOW (dialog), box); -- 2.30.2